cmake: Fix regexp to detect installed FFmpeg version #11554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regexp was not tolerating a + sign is the version string, causing configuration to fail on Ubuntu 24.04 when the installed version is 6.1.1-3ubuntu5+esm2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a
+in the regexp which is used to detect the version of FFmpeg on the system.Motivation and Context
Compiling was failing on my system (Ubuntu 24.04) with cmake complaining about FFmpeg's version. My system version is
6.1.1-3ubuntu5+esm2, which was detected as an empty string because the regexp does not match.How Has This Been Tested?
I successfully compiled OBS.
Types of changes
Checklist: